Skip to content

[3.9] bpo-41193: Ignore OSError in readline write_history() (GH-21279)#21280

Merged
miss-islington merged 1 commit into
python:3.9from
miss-islington:backport-0ab917e-3.9
Jul 2, 2020
Merged

[3.9] bpo-41193: Ignore OSError in readline write_history() (GH-21279)#21280
miss-islington merged 1 commit into
python:3.9from
miss-islington:backport-0ab917e-3.9

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 2, 2020

Copy link
Copy Markdown
Contributor

The write_history() atexit function of the readline completer now
ignores any OSError to ignore error if the filesystem is read-only,
instead of only ignoring FileNotFoundError and PermissionError.
(cherry picked from commit 0ab917e)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue41193

The write_history() atexit function of the readline completer now
ignores any OSError to ignore error if the filesystem is read-only,
instead of only ignoring FileNotFoundError and PermissionError.
(cherry picked from commit 0ab917e)

Co-authored-by: Victor Stinner <vstinner@python.org>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington
miss-islington merged commit 0b4c87e into python:3.9 Jul 2, 2020
@miss-islington
miss-islington deleted the backport-0ab917e-3.9 branch July 2, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants